Fix SOE with select onSend/onReceive clauses on the same channel #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizarov
force-pushed
the
select-send-receive
branch
2 times, most recently
from
c47a800 to
082dbe7
Compare
* Instead of StackOverflowError we throw IllegalStateException and leave the channel in the original state. Fixes #1411
elizarov
force-pushed
the
select-send-receive
branch
from
082dbe7 to
d994b66
Compare
Get rid of private state-reading helper that does "is OpDescriptor" instance check and rearrange the code so that we don't have to do this check on the fast path.
elizarov
force-pushed
the
select-send-receive
branch
from
0c505f6 to
49cb2a1
Compare
The fix is based on the sequential numbering of atomic select operation. Deadlock is detected and the operation with the lower sequential number is aborted and restarted (with a larger number). Fixes #504
elizarov
force-pushed
the
select-send-receive
branch
from
49cb2a1 to
2130949
Compare
|
It does not current passes stress-tests on windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the channel in the original state.
Fixes #1411