Skip to content

StackOverflowError when trying to select onSend and onReceive on the same channel #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qwwdfsad opened this issue Aug 5, 2019 · 0 comments
Closed

StackOverflowError when trying to select onSend and onReceive on the same channel #1411

qwwdfsad opened this issue Aug 5, 2019 · 0 comments
Assignees
@elizarov
Labels
bug

Comments

@qwwdfsad
Copy link
Collaborator

qwwdfsad commented Aug 5, 2019

Steps to reproduce:

@Test
fun foo() = runBlocking {
    val c = Channel<Int>()
    select<Unit> {
        c.onSend(42) {
            println("Sent")
        }
        c.onReceive {
            println("R $it")
        }
    }
}
@qwwdfsad qwwdfsad added the bug label Aug 5, 2019
elizarov added a commit that referenced this issue Aug 7, 2019
@elizarov
Fix SOE with select onSend/onReceive clauses on the same channel
0b89577 
* Instead of StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.

Fixes #1411
@elizarov elizarov mentioned this issue Aug 7, 2019
Closed
elizarov added a commit that referenced this issue Aug 7, 2019
@elizarov
Fix SOE with select onSend/onReceive clauses on the same channel
c47a800 
* Instead of StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.

Fixes #1411
elizarov added a commit that referenced this issue Aug 7, 2019
@elizarov
Fix SOE with select onSend/onReceive clauses on the same channel
082dbe7 
* Instead of StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.

Fixes #1411
elizarov added a commit that referenced this issue Aug 7, 2019
@elizarov
Fix SOE with select onSend/onReceive clauses on the same channel
d994b66 
* Instead of StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.

Fixes #1411
qwwdfsad pushed a commit that referenced this issue Aug 21, 2019
@elizarov @qwwdfsad
Fix SOE with select onSend/onReceive clauses on the same channel
e5f8412 
* Instead of StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.

Fixes #1411
elizarov added a commit that referenced this issue Aug 22, 2019
@elizarov
Fix SOE with select (WIP)
3d731cf 
* onSend/onReceive clauses on the same channel: Instead of
  StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.
* Fix SOE in select with "opposite channels" stress-test. The fix is
  based on the sequential numbering of atomic select operation.
  Deadlock is detected and the operation with the lower sequential
  number is aborted and restarted (with a larger number).

Fixes #504
Fixes #1411
elizarov added a commit that referenced this issue Aug 23, 2019
@elizarov
Fix SOE with select (WIP)
aaef25f 
* onSend/onReceive clauses on the same channel: Instead of
  StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.
* Fix SOE in select with "opposite channels" stress-test. The fix is
  based on the sequential numbering of atomic select operation.
  Deadlock is detected and the operation with the lower sequential
  number is aborted and restarted (with a larger number).

Fixes #504
Fixes #1411
elizarov added a commit that referenced this issue Aug 30, 2019
@elizarov
Fix SOE with select (WIP, DO NOT MERGE)
7e0184a 
* onSend/onReceive clauses on the same channel: Instead of
  StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.
* Fix SOE in select with "opposite channels" stress-test. The fix is
  based on the sequential numbering of atomic select operation.
  Deadlock is detected and the operation with the lower sequential
  number is aborted and restarted (with a larger number).

* TODO:NOTE: SelectDeadlockLFStressTest does not pass and is disabled.
  !!! DO NOT MERGE !!!

Fixes #504
Fixes #1411
elizarov added a commit that referenced this issue Sep 6, 2019
@elizarov
Fix SOE with select (WIP, DO NOT MERGE)
bce71ef 
* onSend/onReceive clauses on the same channel: Instead of
  StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.
* Fix SOE in select with "opposite channels" stress-test. The fix is
  based on the sequential numbering of atomic select operation.
  Deadlock is detected and the operation with the lower sequential
  number is aborted and restarted (with a larger number).

* TODO:NOTE: SelectDeadlockLFStressTest does not pass and is disabled.
  !!! DO NOT MERGE !!!

Fixes #504
Fixes #1411
elizarov added a commit that referenced this issue Sep 6, 2019
@elizarov
Fix SOE with select (WIP, DO NOT MERGE)
ae36c5b 
* onSend/onReceive clauses on the same channel: Instead of
  StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.
* Fix SOE in select with "opposite channels" stress-test. The fix is
  based on the sequential numbering of atomic select operation.
  Deadlock is detected and the operation with the lower sequential
  number is aborted and restarted (with a larger number).

* TODO:NOTE: SelectDeadlockLFStressTest does not pass and is disabled.
  !!! DO NOT MERGE !!!

Fixes #504
Fixes #1411
elizarov added a commit that referenced this issue Sep 7, 2019
@elizarov
Fix SOE with select (WIP, DO NOT MERGE)
5de9d56 
* onSend/onReceive clauses on the same channel: Instead of
  StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.
* Fix SOE in select with "opposite channels" stress-test. The fix is
  based on the sequential numbering of atomic select operation.
  Deadlock is detected and the operation with the lower sequential
  number is aborted and restarted (with a larger number).

* TODO:NOTE: SelectDeadlockLFStressTest does not pass and is disabled.
  !!! DO NOT MERGE !!!

Fixes #504
Fixes #1411
elizarov added a commit that referenced this issue Sep 7, 2019
@elizarov
Fix SOE with select (WIP, DO NOT MERGE)
f314a31 
* onSend/onReceive clauses on the same channel: Instead of
  StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.
* Fix SOE in select with "opposite channels" stress-test. The fix is
  based on the sequential numbering of atomic select operation.
  Deadlock is detected and the operation with the lower sequential
  number is aborted and restarted (with a larger number).

Fixes #504
Fixes #1411
elizarov added a commit that referenced this issue Sep 10, 2019
@elizarov
Fix StackOverflowException with select expressions
7072843 
* onSend/onReceive clauses on the same channel: Instead of
  StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.
* Fix SOE in select with "opposite channels" stress-test. The fix is
  based on the sequential numbering of atomic select operation.
  Deadlock is detected and the operation with the lower sequential
  number is aborted and restarted (with a larger number).

Fixes #504
Fixes #1411
elizarov added a commit that referenced this issue Sep 10, 2019
@elizarov
Fix StackOverflowException with select expressions
a294089 
* onSend/onReceive clauses on the same channel: Instead of
  StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.
* Fix SOE in select with "opposite channels" stress-test. The fix is
  based on the sequential numbering of atomic select operation.
  Deadlock is detected and the operation with the lower sequential
  number is aborted and restarted (with a larger number).

Fixes #504
Fixes #1411
@elizarov elizarov mentioned this issue Sep 10, 2019
Merged
elizarov added a commit that referenced this issue Sep 19, 2019
@elizarov
Fix StackOverflowException with select expressions
769e542 
* onSend/onReceive clauses on the same channel: Instead of
  StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.
* Fix SOE in select with "opposite channels" stress-test. The fix is
  based on the sequential numbering of atomic select operation.
  Deadlock is detected and the operation with the lower sequential
  number is aborted and restarted (with a larger number).

Fixes #504
Fixes #1411
elizarov added a commit that referenced this issue Sep 21, 2019
@elizarov
Fix StackOverflowException with select expressions
6807cf0 
* onSend/onReceive clauses on the same channel: Instead of
  StackOverflowError we throw IllegalStateException and leave
  the channel in the original state.
* Fix SOE in select with "opposite channels" stress-test. The fix is
  based on the sequential numbering of atomic select operation.
  Deadlock is detected and the operation with the lower sequential
  number is aborted and restarted (with a larger number).

Fixes #504
Fixes #1411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elizarov elizarov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elizarov @qwwdfsad