Error parsing triggers: Cannot find module 'kotlinx-atomicfu' with 0.25.3

[SUPERCILEX]

@elizarov Could you please add integration tests? It seems like the atomicfu stuff keeps breaking every other release.

[elizarov]

What kind of integration tests you are looking and what atomicfu stuff keeps breaking? Can you, please, be more specific. Are you referring to #510 here?

[SUPERCILEX]

These: #396, #370

And the current version broke it again.

[SUPERCILEX]

I could give you my project, but you'll have to setup the Firebase CLI.

Run ./gradlew setup && ./gradlew deployServer --only functions:logUserData

[elizarov]

Can you, please, include some relevant pieces of your build log to help me pinpoint the problem? It is really strange, since 0.25.3 coroutines artifacts do not depends on atomicfu both for JVM and JS versions. This dependency is now fully erased and is an internal implementation detail only.

[elizarov]

I've found where the extra dependency on atomicfu-common is leaking (and can fix it), but I cannot reproduce your project on my integration tests -- it seems to be deployed to all the appropriate repos.

[SUPERCILEX]

@elizarov Awesome! And don't worry about my project specifically, I'd just like to see a general "Does this work at runtime" integration test for JS. My project will compile, but it will fail when running firebase deploy and I'm not sure what magic they do to check that stuff.

[elizarov]

I have no idea either, nor I know how to write a test to check. All I can say is that I see all the latest versions of kotlinx-atomicfu deployed to NPMJS, but I also see that NPSJS package.json for kotlinx-coroutines-core does not declare kotlinx-atomicfu as its dependency anymore. You check it here: https://www.npmjs.com/package/kotlinx-coroutines-core

[SUPERCILEX]

Yeah, that's exactly the problem: because it isn't declared, the Firebase thing freaks out. As long as you fix the leak, it should work. 🤷‍♂️

[SUPERCILEX]

BTW, for my project, did you say firebase deploy --only functions:logUserData succeeds?

[elizarov]

Something went wrong with npm upload in this release. Wrong aftefact got uploaded. For JS use 0.25.0 for now, there are no changes. Will fix.

[SUPERCILEX]

SGTM 👍

[LouisCAD]

The title should specify that it only affects JS.