Skip to content

Cannot find module 'atomicfu' #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SUPERCILEX opened this issue Jun 11, 2018 · 2 comments
Closed

Cannot find module 'atomicfu' #396

SUPERCILEX opened this issue Jun 11, 2018 · 2 comments
Assignees
@elizarov
Labels
bug

Comments

@SUPERCILEX
Copy link
Contributor

See #370 (comment)
@elizarov elizarov mentioned this issue Jun 15, 2018
Closed
@elizarov
Copy link
Contributor

Indeed, this is a problem. AtomicFU was published to NPM under the name of kotlinx-atomicfu, yet the main .js file was named atomicfu.js, thus Kotlin/JS compiler emitted require for atomicfu module. Depressingly, all the tests works (since they take artifacts with maven dependencies), yet it would not work in the target project when resolving dependencies via NPM.

@SUPERCILEX
Copy link
Contributor Author

Awesome! I think you should ship a .3 patch since JS has been broken for the past few releases.

@elizarov elizarov self-assigned this Jun 15, 2018
@elizarov elizarov added the bug label Jun 15, 2018
@SUPERCILEX SUPERCILEX mentioned this issue Sep 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elizarov elizarov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elizarov @SUPERCILEX