Skip to content

Fix Instant parsing on Native being too lenient #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dkhalanskyjb
Copy link
Collaborator

No description provided.

@dkhalanskyjb dkhalanskyjb requested a review from ilya-g January 18, 2022 13:34
@ilya-g
Copy link
Member

ilya-g commented Jan 18, 2022

First we need to discuss what behavior we want from Instant.parse. In java.time, for example, Instant.parse does support times like 23:59:60Z.

@dkhalanskyjb
Copy link
Collaborator Author

Closing in favor of #251

@dkhalanskyjb dkhalanskyjb deleted the fix-instant-parsing branch November 29, 2023 15:17
@ilya-g
Copy link
Member

ilya-g commented Dec 8, 2023

I believe we still should discuss how to address an inconsistency between platforms if there is any.

@dkhalanskyjb
Copy link
Collaborator Author

With #251, there isn't: the test from ca34c0a passes for all platforms.

@ilya-g
Copy link
Member

ilya-g commented Dec 16, 2023

There's no inconsistency between platforms in kotlinx.datetime, but there's inconsistency between kotlinx.datetime and java.time in Instant.parse. Let's reopen.

@dkhalanskyjb
Copy link
Collaborator Author

Ok: #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants