Test that 60 seconds and 24 hours are not parsed for Instant

dkhalanskyjb · dkhalanskyjb · commit ca34c0abb0bb · 2023-12-05T14:34:00.000+01:00
diff --git a/core/common/test/InstantTest.kt b/core/common/test/InstantTest.kt
@@ -86,7 +86,8 @@ class InstantTest {
             assertEquals(seconds.toLong() * 1000 + nanos / 1000000, instant.toEpochMilliseconds())
         }
 
-        // TODO: assertInvalidFormat { Instant.parse("1970-01-01T23:59:60Z")} // fails on Native
+        assertInvalidFormat { Instant.parse("1970-01-01T23:59:60Z")}
+        assertInvalidFormat { Instant.parse("1970-01-01T24:00:00Z")}
         assertInvalidFormat { Instant.parse("x") }
         assertInvalidFormat { Instant.parse("12020-12-31T23:59:59.000000000Z") }
         // this string represents an Instant that is currently larger than Instant.MAX any of the implementations:

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,8 @@ class InstantTest {`
`86`	`86`	`assertEquals(seconds.toLong() * 1000 + nanos / 1000000, instant.toEpochMilliseconds())`
`87`	`87`	`}`
`88`	`88`
`89`		`- // TODO: assertInvalidFormat { Instant.parse("1970-01-01T23:59:60Z")} // fails on Native`
	`89`	`+ assertInvalidFormat { Instant.parse("1970-01-01T23:59:60Z")}`
	`90`	`+ assertInvalidFormat { Instant.parse("1970-01-01T24:00:00Z")}`
`90`	`91`	`assertInvalidFormat { Instant.parse("x") }`
`91`	`92`	`assertInvalidFormat { Instant.parse("12020-12-31T23:59:59.000000000Z") }`
`92`	`93`	`// this string represents an Instant that is currently larger than Instant.MAX any of the implementations:`