Update of master #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederic Pillon <[email protected]>
If HAL_ADC_MODULE_ENABLED and HAL_DAC_MODULE_ENABLED are not defined it is not used. No more used if HAL_TIM_MODULE_ENABLED since HardwareTimer. Signed-off-by: Frederic Pillon <[email protected]>
If no analog pin required then `NUM_ANALOG_INPUTS` and `NUM_ANALOG_FIRST` could be not defined or set to respectively `0` and `NUM_DIGITAL_PINS` Nevertheless, this kept ADC internal channels functional if `HAL_ADC_MODULE_ENABLED` still defined. Signed-off-by: Frederic Pillon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, Make sure that your PR is not a duplicate.
Search among the Pull request before creating one.
IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.
Thanks for submitting a pull request.
Please provide enough information so that others can review your pull request:
Summary
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
Validation
Code formatting
Closing issues
Fixes #xxx