Update AzureIoT Library with support for more boards #1
Conversation
move/rename esp samples so they show up in ide
| @@ -1,14 +1,75 @@ | |||
| # AzureIoT - Azure IoT library for Arduino | |||
| # AzureIoT - Azure IoT Hub library for Arduino | |||
|
|
|||
There was a problem hiding this comment.
Do you think the library should be renamed to "AzureIoTHub" as well?
There was a problem hiding this comment.
We've agreed to rename this repo to AzureIoTHub.
|
@stefangordon @obsoleted great work on adding new board support! I'm done with my comments for now, overall summary:
|
|
Thanks Sandeep! We'll incorporate most of these changes in the next day or so. The logging issue is challenging due to some unique issues with ESP8266, but we are working through getting it resolved through a redesign of logging in the SDK. I'll also file issues for work items and improvements we are still tracking. |
- Avoid code duplciation by combining the arch specific httpsclient
implementations and using #ifdef-ing for unique bits (as they are only
in includes and class definition now
- Similarly for samd use a common NTPClient header for both adafruit
and arduino boards
Updates based on feedback
Move NTP stuff to sketch for SAMD and other fixes
Temporary sync solution until vnext is implemented.
|
Alright I think we are in decent shape here now. There will be continuous work/improvements over the next few weeks but this is stable enough to unblock people. We have tested on ESP8266 boards (Huzzah and Sparkfun Thing) as well as Adafruit Feather M0 (SAMD). We were not able to do MKR1000 or Zero yet. |
- Remove dead code
- Update Readme for removed sample
- Use consistent logging statements in esp sample
- update pgmspace helper to ignore for samd building (only build for
esp)
Esp fix and samples
|
Thanks for the comments so far @sandeepmistry. I believe we have addressed them in the new commits. Do you have any other issues or concerns with accepting this? |
| 4. Update IoT Hub Connection string in simplesample_http.c | ||
|
|
||
| ## MKR1000 or Zero + Wifi101 | ||
| 1. Open the AzureIoTHub SAMD sample from the Arduino IDE File->Examples menu. |
There was a problem hiding this comment.
Note: the library is still name AzureIoT, however if you think AzureIoTHub is a better name we can rename the repo and library.properties.
There was a problem hiding this comment.
That is a good idea. Library.properties has been updated, updating the repo name also seems reasonable.
There was a problem hiding this comment.
Cool, I'll do so after this is merged. We'll have to do some clean up to remove older releases with the old name.
|
@obsoleted I've added a few more review comments, but overall new changes look good. |
|
@sandeepmistry Thanks for the comments. I've made some replies. And added the commit saving. Again, we do hope to make continuous improvements to the library. Part of that will be getting this out there to start getting feedback on it. |
…g / command center samples added.
ESP8266 (Huzzah and Thing Dev) and SAMD (Feather M0) remote monitorin…
| #elif defined(ARDUINO_SAMD_ZERO) || defined(ARDUINO_SAMD_MKR1000) | ||
| WiFiUDP _udp; | ||
| #endif | ||
|
|
There was a problem hiding this comment.
I don't see _udp used in this function, can we remove this?
Update AzureIoT Library with support for more boards
Significant changes to support Adafruit Feather M0 Wifi and all ESP8266 boards. MKR1000 support will be verified as it is released.
This has the latest Azure SDK bits and a modified sync script. We are evaluating publishing SDK updates to this repo as part of our core SDK repo publishing process soon.
I'm a Microsoft engineer working with the Azure IoT Hub team to build out this library to support as many devices as possible. We are continuing to build out documentation and test on additional boards, but this has been tested on available SAMD and ESP8266 boards. I am happy to be collaborator on the core repository here and own testing and maintenance if appropriate as we have resources allocated to continue to improve this library.
This requires Arduino IDE 1.6.8.
Thanks!