Skip to content

Test on push (not just on pull request) #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

jgfoster
Copy link
Member

I found that when I made a change and pushed to my fork the tests were not run. I'd like to have them run so I can confirm my work before I submit a Pull Request. This addresses that need.

@jgfoster jgfoster changed the title Set all text files to have LF endings Test on push (not just on pull request) Feb 16, 2021
@ianfixes
Copy link
Collaborator

ianfixes commented Apr 5, 2021

In my local branch, I had enabled "Test on push" for just the Linux runner, is that sufficient? I can also make the change in the documentation ("produces" -> "should produce") if so.

@jgfoster
Copy link
Member Author

jgfoster commented Apr 5, 2021

Yes, Linux would should be sufficient. ;-)

Copy link
Collaborator

@ianfixes ianfixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reading the GitHub docs about billing, all open-source repositories seem to be allowed no-cost use of GitHub Actions... so there is no financial impact to this change (which was my original reason for not testing both pushes and pull requests)

@jgfoster jgfoster merged commit 115eb01 into Arduino-CI:master Sep 23, 2021
@jgfoster jgfoster deleted the test_on_push branch September 23, 2021 15:08
Copy link
Contributor

@prestoncarman prestoncarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants