Skip to content

Commit 115eb01

Browse files
author
James Foster
authored
Merge pull request #284 from jgfoster/test_on_push
Test on push (not just on pull request)
2 parents d058804 + 1287b51 commit 115eb01

File tree

5 files changed

+5
-4
lines changed

5 files changed

+5
-4
lines changed

Diff for: .github/workflows/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ In this project, we define a workflow for each target platform. **If you're loo
77

88
The reason that all platforms are tested in _this_ project is to ensure that, as a framework, `arduino_ci` will run properly on any developer's personal workstation (regardless of OS).
99

10-
For testing an individual Arduino library in the context of GitHub, [Linux is the cheapest option](https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions) and produces results identical to the other OSes.
10+
For testing an individual Arduino library in the context of GitHub, [Linux is the cheapest option](https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions) and should produce results identical to the other OSes.

Diff for: .github/workflows/linux.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# This is the name of the workflow, visible on GitHub UI
22
name: linux
33

4-
on: [pull_request]
4+
on: [push, pull_request]
55

66
jobs:
77
"unittest_lint_sampleproject":

Diff for: .github/workflows/macos.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# This is the name of the workflow, visible on GitHub UI
22
name: macos
33

4-
on: [pull_request]
4+
on: [push, pull_request]
55

66
jobs:
77
"unittest_lint_sampleproject":

Diff for: .github/workflows/windows.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# This is the name of the workflow, visible on GitHub UI
22
name: windows
33

4-
on: [pull_request]
4+
on: [push, pull_request]
55

66
jobs:
77
"unittest_lint_sampleproject":

Diff for: CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1212

1313
### Changed
1414
- Change 266 files from CRLF to LF.
15+
- Run tests on push as well as on a pull request so developers can see impact
1516

1617
### Deprecated
1718

0 commit comments

Comments
 (0)