zephyrCommon: Implement analogWrite() #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soburi
force-pushed
the
pwm
branch
3 times, most recently
from
b32d822 to
f3b7ebe
Compare
DhruvaG2000
requested changes
Sep 25, 2022
samples/fade/prj.conf
Outdated
| @@ -0,0 +1,4 @@ | |||
| CONFIG_CPLUSPLUS=y | |||
| CONFIG_ARDUINO_API=y | |||
| CONFIG_GPIO=y | |||
There was a problem hiding this comment.
Same here, gpio and CPP seem redundant
samples/fade/src/app.cpp
Outdated
| */ | ||
|
|
||
| #include <Arduino.h> | ||
| #include "zephyrSerial.h" |
There was a problem hiding this comment.
including zephyrSerial shouldn't really be necessary as it is included in Arduino.h itself.
| pinctrl-0 = <&pwm1_default>; | ||
| pinctrl-1 = <&pwm1_sleep>; | ||
| pinctrl-names = "default", "sleep"; | ||
| }; |
There was a problem hiding this comment.
Having documentation as to what all needs to be added in overlays might help here as well.
The 'pwms' node under the 'zephyr,user' defines available PWM channels. The 'pwm-pins' defines the mapping of PWM channels to pin numbers. API looks up the 'pwm-pins' when querying the PWM channel by digital pin number. So it should be in the same order as 'pwms' node. PWM channels should configure and tied to the output pins. The period property of the PWM channel is used as resolution as PWM. For original Arduino API compatibility, it should be 255. The period property and API argument determines the duty ratio. Signed-off-by: TOKITA Hiroshi <[email protected]>
DhruvaG2000
approved these changes
Sep 25, 2022
|
I thought I would have rebase access, but seems like I can't squash commits, please can you squash my last commit in previous one? |
Added a fade sample to demonstrate how to use analogWrite API Signed-off-by: TOKITA Hiroshi <[email protected]>
squash and update done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'pwms' node under the 'zephyr,user' defines available PWM channels.
The 'pwm-pins' defines the mapping of PWM channels to pin numbers.
API looks up the 'pwm-pins' when querying the PWM channel by digital pin number.
So it should be in the same order as 'pwms' node.
PWM channels should configure and tied to the output pins.
The period property of the PWM channel is used as resolution as PWM.
For original Arduino API compatibility, it should be 255.
The period property and API argument determines the duty ratio.
I verified this PR with mkrzero and nano_33_ble.
Some pins of the mkrzero seem not to work correctly.
Only verified configuration only enableed.