zephyrCommon: Implement attachInterrupt()/detachInterrupt() #51
Conversation
|
I'm testing with nrf52840 with this patch https://github.com/soburi/zephyr/tree/nrfx_gpio_get_config |
soburi
force-pushed
the
attachInterrupt
branch
from
85a4871 to
d2c2059
Compare
soburi
force-pushed
the
attachInterrupt
branch
from
d2c2059 to
e65b7bf
Compare
soburi
force-pushed
the
attachInterrupt
branch
2 times, most recently
from
c01299f to
98cd47f
Compare
samples/attach_interrupt/prj.conf
Outdated
| @@ -0,0 +1,4 @@ | |||
| CONFIG_GPIO=y | |||
| CONFIG_CPLUSPLUS=y | |||
There was a problem hiding this comment.
The module Kconfig already takes care of CPP and GPIO configs, if ARDUI API is enabled, so this can be dropped from prj.conf
imply CPLUSPLUS
imply GPIO
There was a problem hiding this comment.
@soburi can you take a look at if this is required again please?
There was a problem hiding this comment.
Removed CONFIG_CPLUSPLUS and CONFIG_GPIO.
soburi
force-pushed
the
attachInterrupt
branch
from
98cd47f to
ef0fc41
Compare
cores/arduino/zephyrCommon.cpp
Outdated
| } | ||
| } | ||
|
|
||
| void pinModeImpl(pin_size_t pinNumber, gpio_flags_t pinmode, voidFuncPtr callback, gpio_flags_t intmode) |
There was a problem hiding this comment.
It seems like this PR is doing much more than just Implementing attachInterrupt()/detachInterrupt, and thus in my opinion deserves to have it's own commit that separates the modifications that have been made in the way that pinMode was earlier implemented.
There was a problem hiding this comment.
Also if possible, the commit message should justify the use of new pinMode being better than earlier one and also the addition of GPIO_MODE_MASK instead of directly using each individual GPIO_XX flag as and when required?
There was a problem hiding this comment.
As a result of redesign, I was able to eliminate this.
It's just attachInterrupt/detachInterrupt and their internal implementation.
soburi
force-pushed
the
attachInterrupt
branch
from
ef0fc41 to
3c9c270
Compare
|
Redesign based on #60. |
|
Any reason this is still a draft PR? Please mark as ready if you want it to be reviewed, |
soburi
force-pushed
the
attachInterrupt
branch
from
3c9c270 to
9df6b4c
Compare
The internal data structure named `gpio_port_callback` stores GPIO callback handlers. The `gpio_port_callback` allocate the data per GPIO device. The `gpio_port_callback` has an array of function pointers to store handler. The largest count of the gpio pin count among the GPIO devices that using (which means it exists in the `digital-pin-gpios`) determines the array size. It calculates the data size at compile time. Signed-off-by: TOKITA Hiroshi <[email protected]>
Add a sample to demonstrate how to use attachInterrupt Signed-off-by: TOKITA Hiroshi <[email protected]>
soburi
force-pushed
the
attachInterrupt
branch
from
9df6b4c to
793c765
Compare
There was a problem hiding this comment.
Tested on my ble sense 33 and I was able to toggle LED by giving interrupts on D2 pin.
Hence,
Tested-by: Dhruva Gole
Thanks for this great feature addition @soburi !
This implementation depends on CONFIG_GPIO_GET_CONFIG
to keep the GPIO state already configured by pinMode().