Skip to content

variants: Rename variants.h to variant.h #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

soburi
Copy link
Member

@soburi soburi commented Aug 4, 2024

The header for Arduino board-specific settings is variant.h, not variants.h, so I modified it accordingly.

such as:
https://github.com/arduino/ArduinoCore-samd/blob/master/variants/arduino_zero/variant.h

Copy link
Collaborator

@DhruvaG2000 DhruvaG2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix spelling of rename in $subject please, Rest is good.

The header for Arduino board-specific settings is variant.h,
not variants.h, so I modified it accordingly.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi soburi changed the title variants: Renamve variants.h to variant.h variants: Rename variants.h to variant.h Aug 6, 2024
@soburi
Copy link
Member Author

soburi commented Aug 6, 2024

Fix spelling of rename in $subject please, Rest is good.

Oops... That's Embarrassing!
Fixed it.

@soburi soburi requested a review from DhruvaG2000 August 6, 2024 06:39
@DhruvaG2000 DhruvaG2000 merged commit 3538c54 into zephyrproject-rtos:next Aug 12, 2024
1 of 2 checks passed
@soburi soburi deleted the variant_h branch August 13, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants