Skip to content

Installation: delete step to comment out WCharacter from ArduinoCore API #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024
+0 −6
Merged

Installation: delete step to comment out WCharacter from ArduinoCore API #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ The `cores` folder can be found at `~/zephyrproject/modules/lib/Arduino-Zephyr-A

__NOTE:__ You can skip this step as well if you ran ``install.sh``.

* While compiling with the ArduinoCore-API `WCharacter.h` produces many errors. The include of that file needs to be deleted from `cores/arduino/api/ArduinoAPI.h` (it is unused in this port.) We are looking into resolving the issue.

**Maintainers**:
- [DhruvaG2000](https://github.com/DhruvaG2000)
- [soburi](https://github.com/soburi)
Expand Down
4 changes: 0 additions & 4 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ else
printf '%s\n' "API Folder already exists, skipping clone...";
fi

printf '%s\n' "Commenting out WCharacter.h because it fails to build properly";
sed '/WCharacter.h/ s/./\/\/ &/' ~/.ArduinoCore-API/api/ArduinoAPI.h > ~/.ArduinoCore-API/api/tmpArduinoAPI.h ;
mv ~/.ArduinoCore-API/api/tmpArduinoAPI.h ~/.ArduinoCore-API/api/ArduinoAPI.h ;

printf '%s\n' "Linking...";
ln -sf ~/.ArduinoCore-API/api cores/arduino/. ;

Expand Down
Loading