Update README.md #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeonjuan
pushed a commit
that referenced
this pull request
Dec 29, 2024
…te functions' return statements (typescript-eslint#10106) * initial implementation * tests * refactor * some more tests * update docs * update snapshots * handle implicit or explicit undefined return types * refactor and update tests * remove unnecessary union check * inline check * cover empty return staetments * report a function as returning undefined only if no other isssues were found * update comments * add test * remove unnecessary test * update code to match function's inferred return type rather than each return statement individually * update tests to match the implementation changes * adjust suggestion message * final adjustments * final adjustments #2 * test additions * update snapshots * Update packages/eslint-plugin/docs/rules/strict-boolean-expressions.mdx Co-authored-by: Kirk Waiblinger <[email protected]> * initial implementation of deducing the correct signature for non-function-expressions * comments * take type constraints into consideration * only check type constraints on type parameters * update tests * update index tests * update snapshot * simplify code a bit * remove overly complex heuristic * use an existing helper rather than implementing one * update tests * Update packages/eslint-plugin/src/rules/strict-boolean-expressions.ts Co-authored-by: Kirk Waiblinger <[email protected]> * fix codecov * cleanup old code, support type constraints * refactor fixer * remove unnecessary tests * revert changes to isParenlessArrowFunction * oops --------- Co-authored-by: Kirk Waiblinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview