Skip to content

Moved dialect resolution logic into JdbcConfiguration #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Moved dialect resolution logic into JdbcConfiguration #177

wants to merge 1 commit into from

Conversation

mipo256
Copy link
Contributor

@mipo256 mipo256 commented Feb 17, 2025 •
edited
Loading

The problem is that JdbcDialectProviders are only loaded from spring.factories. In order to utilize YdbDialectProvider without spring.factories we need to use it AbstractYdbcJdbcConfiguration

@mipo256 mipo256 marked this pull request as ready for review February 17, 2025 19:33
@mipo256
Copy link
Contributor Author

mipo256 commented Feb 18, 2025

Decided to retain DialectProvider in the spring.factories, to not introduce a change.

CC: @KirillKurdyukov

@mipo256 mipo256 closed this Feb 18, 2025
@KirillKurdyukov KirillKurdyukov linked an issue Feb 18, 2025 that may be closed by this pull request
feat: A better way of discovering the infrastructure beans #176
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: A better way of discovering the infrastructure beans
1 participant
@mipo256