GH-174 #175
Merged
GH-174 #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ata-jdbc-ydb/src/main/java/tech/ydb/data/repository/config/AbstractYdbJdbcConfiguration.java
Outdated
Show resolved
Hide resolved
KirillKurdyukov
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Solving #174.
Spring Data, as of 3.4, does not expose the repository invocation metadata unless explicitly specified to do so. The motivation for this change is that adding an Advisor for exposing methods is a bit resource intensive.
Unfortunately, we cannot really do anything in the dialect itself, since the
Dialectby its design, is supposed to work on SQL level only. That is to say, it does not know anything aboutPersistentEntityor theQueryExecutorMethodInterceptor.So, what we're actually doing is - we're enabling the metadata exposure per
RepositoryFactoryBeanSupport-basis. That is to say, we do not enable it for every repository in the system. We're just enabling it for those that require that, in our case, annotated with@ViewIndex