Skip to content

Fix regression introduced by #68 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

wol-soft
Copy link
Owner

Validators which render a separate method and are transferred to a parent schema will render the method to the origin schema. Consequently, a call to the validator in the parent schema will cause a "call to undefined method" error. To fix the issue the validator scope gets updated at render time to make sure the method is rendered to the correct class.

Validators which render a separate method and are transferred to a parent schema will render the method to the origin schema. Consequently, a call to the validator in the parent schema will cause a "call to undefined method" error. To fix the issue the validator scope gets updated at render time to make sure the method is rendered to the correct class.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4574843470

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 98.722%

Totals Coverage Status
Change from base Build 4564521612: 0.002%
Covered Lines: 2781
Relevant Lines: 2817

💛 - Coveralls

@wol-soft wol-soft merged commit e1968a0 into master Mar 31, 2023
@wol-soft wol-soft deleted the 65-recursive-reference-resolving branch March 31, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants