Optimize exceptions for nested objects #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently validation errors for nested objects are handled identically to the errors of the parent object. This may lead to confusing errors:
Initializing a object like
new Person(['name' => false, 'pet' => ['name' => false]]);
will throw an exception with the message:If only one name validation fails the exception isn't helpful to detect whether the name of the main object isn't valid or the name of the nested object.
This PR adds a
NestedObjectException
wrapping exceptions from nested object instantiation. TheNestedObjectException
will additionally change the output behaviour of the exception so the exception for the example given above will look like: