Skip to content

Optimize merged properties #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 8, 2020
Merged

Optimize merged properties #13

merged 4 commits into from
Jul 8, 2020

Conversation

wol-soft
Copy link
Owner

  • Don't create a merged property for compositions on object level
  • Resolve merged properties TODOs

@wol-soft
Don't create a useless merged property if the composition is defined …
ea4458a 
…on object-level. Instead only define a merged property if the composition is used for an object property (#5)
@wol-soft wol-soft self-assigned this Jun 29, 2020
@wol-soft wol-soft added the enhancement New feature or request label Jun 29, 2020
@wol-soft wol-soft linked an issue Jun 29, 2020 that may be closed by this pull request
Don't create a merged property if the composition is on object level #5
Closed
@coveralls
Copy link

coveralls commented Jun 29, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 256

  • 33 of 33 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 97.724%
Totals Coverage Status
Change from base Build 247: 0.04%
Covered Lines: 1417
Relevant Lines: 1450
💛 - Coveralls

wol-soft added 3 commits June 29, 2020 20:30
@wol-soft
Remove unnecessary code, extend merged property documentation
a469d0e
@wol-soft
Redirect before generating a merged property if
30eb113 
 * no composition element contains a nested schema (in this case redirect to null)
 * only one composition element contains a nested schema (in this case redirect to the already created class)

If all elements of a composition provide the same type and the property defining the composition has no type definition transfer the type information so the property is typed correctly
@wol-soft
Added additional test cases for a composition containing multiple ele…
65d50fc 
…ments with nested schemas and elements without nested schema
@wol-soft wol-soft merged commit 4e9ede1 into master Jul 8, 2020
@wol-soft wol-soft deleted the OptimizeMergedProperties branch July 8, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wol-soft wol-soft

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't create a merged property if the composition is on object level
2 participants
@wol-soft @coveralls