Skip to content

use github actions #4035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Nov 13, 2020
Merged

Conversation

chenxsan
Copy link
Member

@chenxsan chenxsan commented Oct 7, 2020

Travis provides 5 concurrent builds for open source builds, and it's sort of limited for a project like webpack documentation. This pull request #4032 was postponed for many minutes as there're other jobs running, and it's a waste of time. I'm wondering if github actions can improve the situation.

@vercel
Copy link

vercel bot commented Oct 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/2didem5yc
✅ Preview: https://webpack-js-org-git-feature-use-github-actions.webpack-docs.vercel.app

@chenxsan chenxsan marked this pull request as ready for review October 7, 2020 13:34
@chenxsan chenxsan marked this pull request as draft October 7, 2020 13:48
@jeffin143
Copy link
Contributor

azure has good build prospects too, I guess we could try that too

@montogeek
Copy link
Member

It is there a comparison between all 3 (or some more)? I know Actions will only give us 2000 minutes per month, right now in Travis (completely infrastructure) it takes 10 mins, so we will get 200 jobs per month, give or take. It is this better than Travis?

@chenxsan
Copy link
Member Author

chenxsan commented Oct 7, 2020

@montogeek Thanks for the information, I just took it for granted that github provides open source projects unlimited time as it mentioned free in its page:

image

I'll do more research later.

@chenxsan
Copy link
Member Author

chenxsan commented Oct 8, 2020

CI runs much faster now (before: ~16min, after: ~8min) after this pull request #4033, it's acceptable in my opinion, so I'll close this PR.

@chenxsan chenxsan closed this Oct 8, 2020
@chenxsan
Copy link
Member Author

chenxsan commented Oct 9, 2020

@montogeek FYI, I've written an email to github for clarifying and here's their answer:

image

@alexander-akait
Copy link
Member

I think in long term will be great to migration on github actions (a lot of features)

@chenxsan
Copy link
Member Author

chenxsan commented Oct 9, 2020

Maybe we can enable github actions along with travis for a while to see how one compared to another. When we collect enough data we can make a final decision which to use.

@alexander-akait
Copy link
Member

alexander-akait commented Oct 9, 2020

Good idea

@chenxsan chenxsan reopened this Oct 9, 2020
@montogeek
Copy link
Member

I will prefer GitHub actions just because everything will be here :)

@chenxsan
Copy link
Member Author

With cache enabled, the Lint job can run in 1m https://github.com/chenxsan/webpack.js.org/actions/runs/300387454:

image

I think it's quite promising compared to travis:

image

This reverts commit 97c5ea9.
@chenxsan
Copy link
Member Author

chenxsan commented Oct 11, 2020

Seems github actions can run multiple jobs simultaneously which bring a faster result than travis even though the Proselint job runs slower than travis.

@chenxsan chenxsan marked this pull request as ready for review October 13, 2020 14:17
@chenxsan
Copy link
Member Author

chenxsan commented Oct 13, 2020

Since I can't test the deploy job, I've included an empty deploy-github.sh for testing. We can update it later if we decide to migrate to actions.

@chenxsan
Copy link
Member Author

With the new pricing model introduced recently in travis https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing, the time spent running CI is much longer than before now. Thus I'm going to merge this PR once the CI pass so we can monitor the performance of Github Actions along with travis.

@chenxsan
Copy link
Member Author

30 minutes, and it's not done yet.

image

@chenxsan chenxsan closed this Nov 13, 2020
@chenxsan chenxsan reopened this Nov 13, 2020
@chenxsan chenxsan merged commit ccb20eb into webpack:master Nov 13, 2020
@chenxsan chenxsan deleted the feature/use-github-actions branch November 13, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants