Skip to content

test(client): added clientMode option test #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

knagaitsev
Copy link
Collaborator

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

I should have added this earlier, but this simply confirms that the server is passing stuff into the clientMode helper correctly, and is throwing with bad clientMode.

Breaking Changes

None

Additional Info

I will add this mocking method to check serverMode helper usage if it looks fine.

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #2078 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2078      +/-   ##
==========================================
+ Coverage   92.75%   92.92%   +0.16%     
==========================================
  Files          32       32              
  Lines        1201     1201              
  Branches      335      335              
==========================================
+ Hits         1114     1116       +2     
+ Misses         83       81       -2     
  Partials        4        4
Impacted Files Coverage Δ
client-src/clients/SockJSClient.js 100% <0%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 764b24e...49d739d. Read the comment docs.

@alexander-akait
Copy link
Member

/cc @hiroppy

@hiroppy hiroppy merged commit f984e53 into webpack:master Jun 28, 2019
knagaitsev added a commit to knagaitsev/webpack-dev-server that referenced this pull request Jul 31, 2019
@knagaitsev knagaitsev added gsoc Google Summer of Code scope: ws(s) labels Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc Google Summer of Code scope: ws(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants