Skip to content

Fix: Default to localhost when no host option, remove entries that are now added automatically #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2019

Conversation

knagaitsev
Copy link
Collaborator

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes, added a new test for createDomain.

Motivation / Use-Case

Fixes #1743

  • Removed one of the entry scripts from the api examples because that is now added automatically
  • createDomain should default to localhost when the options.host is not provided, that is what was resulting in 'http:/sockjs-node' without the hostname in the middle.

Breaking Changes

None

Additional Info

@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #1750 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1750   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files           9        9           
  Lines         578      578           
  Branches      170      170           
=======================================
  Hits          502      502           
  Misses         63       63           
  Partials       13       13
Impacted Files Coverage Δ
lib/utils/createDomain.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f899ff...f1c3b9a. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks

@alexander-akait alexander-akait merged commit 732e6c5 into webpack:master Apr 3, 2019
@knagaitsev knagaitsev added the gsoc Google Summer of Code label Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc Google Summer of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught SyntaxError: The URL 'http:/sockjs-node' is invalid
2 participants