refactor: use express recommended api

[nuintun]

This PR contains a:

• bugfix
• new feature
• code refactor
• test update
• typo fix
• metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

[codecov]

Codecov Report

Merging #727 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #727   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          10       10           
  Lines         234      235    +1     
  Branches       71       71           
=======================================
+ Hits          233      234    +1     
  Misses          1        1           

Impacted Files	Coverage Δ
src/utils/handleRangeHeaders.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07244b0...09b8c4a. Read the comment docs.

[hiroppy]

thanks, but is this necessary changes?

[nuintun]

@hiroppy In v4.0.0-rc.3 if I hack with koa:

const expressMiddleware = require('webpack-dev-middleware').default;

module.exports = (compiler, options) => {
  const middleware = expressMiddleware(compiler, options);

  const devMiddleware = async (ctx, next) => {
    const locals = ctx.state;
    const set = ctx.set.bind(ctx);
    const get = ctx.get.bind(ctx);
    const send = content => (ctx.body = content);

    await middleware(ctx.request, { set, get, send, locals, setHeader: set }, next);
  };

  Object.keys(middleware).forEach(key => {
    devMiddleware[key] = middleware[key];
  });

  return devMiddleware;
};

set and setHeader ??

#617 might be a better solution!

[alexander-akait]

@nuintun sorry we never support koa, if you want to support it, please send a PR with tests too

[nuintun]

@evilebottnawi This PR is only for unified API usage, not for compatibility with koa!

webpack-dev-middleware/src/middleware.js

Line 64 in 49a1203

res.set('Content-Type', contentType);

webpack-dev-middleware/src/utils/handleRangeHeaders.js

Line 13 in 49a1203

res.setHeader('Content-Range', `bytes */${content.length}`);

[alexander-akait]

oh, yes, thanks for the PR

[alexander-akait]

Thanks!