fix: copy options json file over during build #590
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScriptedAlchemy
requested review from
alexander-akait and
hiroppy
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 8 8
Lines 228 228
Branches 71 71
=======================================
Hits 226 226
Misses 2 2 Continue to review full report at Codecov.
|
when publishing, then options.json file is not copied into the dist directory causing anything using the release candidate to fail
ScriptedAlchemy
force-pushed
the
fix-failing-build
branch
from
c4db799 to
0aacbfa
Compare
|
I think we can close it in favor #589 |
|
All good. As long as its fixed :) Thanks man |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
I cant use v4 with Webpack 5.
When publishing, then options.json file is not copied into the dist directory causing anything using the release candidate to fail
Breaking Changes
Additional Info
fix: #588