Skip to content
This repository was archived by the owner on Dec 5, 2019. It is now read-only.

refactor: changed __UglifyJsPlugin dereference to use WeakSet instead #57

Merged
merged 1 commit into from
Jun 29, 2017
Merged

refactor: changed __UglifyJsPlugin dereference to use WeakSet instead #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@ class UglifyJsPlugin {
// eslint-disable-next-line prefer-spread
files.push.apply(files, compilation.additionalChunkAssets);
const filteredFiles = files.filter(ModuleFilenameHelpers.matchObject.bind(undefined, options));
const uglifiedAssets = new WeakSet();
filteredFiles.forEach((file) => {
const oldWarnFunction = uglify.AST_Node.warn_function;
const warnings = [];
let sourceMap;
try {
const asset = compilation.assets[file];
if (asset.__UglifyJsPlugin) {
compilation.assets[file] = asset.__UglifyJsPlugin;
if (uglifiedAssets.has(asset)) {
return;
}
let input;
Expand Down Expand Up @@ -220,9 +220,7 @@ class UglifyJsPlugin {
}
}
}
compilation.assets[file] = outputSource;
asset.__UglifyJsPlugin = outputSource;

uglifiedAssets.add(compilation.assets[file] = outputSource);
if (warnings.length > 0) {
compilation.warnings.push(new Error(`${file} from UglifyJs\n${warnings.join('\n')}`));
}
Expand Down