Skip to content

replace expensive search method with efficient bottom-to-top one #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

NeKJ
Copy link

@NeKJ NeKJ commented Mar 9, 2020

currently the method that searches the .js files for the sourceMap directive is costly and that contributes a lot with largish dependencies to the final build time of a project.

This is a different approach to conduct the same search with the same results (passes all the issued tests) that is efficient for larger dependencies. i.e. in our project the source-map-loader took ~15 seconds and with this takes only 3-4ms.

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@cap-Bernardito cap-Bernardito mentioned this pull request May 22, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants