Skip to content

increase source-map package version ( Cannot read property 'substr' of undefined err ) #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmitry-kurmanov opened this issue Oct 2, 2017 · 7 comments

Comments

@dmitry-kurmanov
Copy link

dmitry-kurmanov commented Oct 2, 2017

Hello, team! Thanks for your work! Can you increase source-map package version to the latest (~0.6.1)? This is need beacuse of bug in source-map package: mozilla/source-map#247. I am using preact and the bug is reproducing for me.

and the same webpack/webpack-sources#27

@Hotell
Copy link

Hotell commented Oct 23, 2017

same here

@alexander-akait
Copy link
Member

@Hotell done #56

@Hotell
Copy link

Hotell commented Oct 23, 2017

release new version plzzzzzz 🍻

@Hotell
Copy link

Hotell commented Nov 2, 2017

strange thing is, that update loader still doesn't work with latest webpack :(

@alexander-akait
Copy link
Member

@Hotell please create minimum reproducible test repo, thank you!

@tomasdev
Copy link

tomasdev commented Nov 3, 2017

Not sure if this is even possible, but when having multiple dependencies on a project (i.e., babel-cli) it's not always taking the highest version of the sub-dependency.

Given [email protected] and [email protected] it ends up installing [email protected] :(

I have tried explicitly adding "source-map": "^0.6.1", to my package.json without success

UPDATE: seems to be specific to webpack #54

@tomasdev
Copy link

tomasdev commented Nov 3, 2017

Alt solution until this is merged:

  1. npm shrinkwrap will generate a npm-shrinkwrap.json
  2. Find "webpack-sources": { and replace it with:
      "version": "1.0.1",
      "from": "webpack-sources@>=1.0.1 <2.0.0",
      "resolved": "https://registry.npmjs.org/webpack-sources/-/webpack-sources-1.0.1.tgz",
      "dev": true,
      "dependencies": {
        "source-map": {
          "version": "0.6.1",
          "from": "source-map@>=0.5.3",
          "resolved": "https://registry.npmjs.org/source-map/-/source-map-0.6.1.tgz",
          "dev": true
        }
      }
    },

n-joy

@michael-ciniawsky michael-ciniawsky removed this from the 0.2.4 milestone Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants