docs(readme): update getting started instructions #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add instruction to install postcss-preset-env in getting started section because it is used in the boilerplate configuration closes issue webpack-contrib#548
|
|
This reverts commit 0c00f48.
…ig example add note that postcss-preset-env is not installed by default in getting started section because it is used in the boilerplate configuration closes webpack-contrib#548
alexander-akait
approved these changes
Oct 13, 2021
|
Please accept CLA |
|
Accepted |
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
==========================================
- Coverage 93.58% 93.26% -0.33%
==========================================
Files 5 5
Lines 312 312
Branches 101 101
==========================================
- Hits 292 291 -1
- Misses 18 19 +1
Partials 2 2
Continue to review full report at Codecov.
|
martenmatrix
deleted the
add-postcss-preset-env-to-installation-command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
In the Getting Started section, it should tell you to also install postcss-preset-env because in the provided boilerplate-configuration, the plugin is used.
This line npm install --save-dev postcss-loader postcss should change to npm install --save-dev postcss-loader postcss postcss-preset-env.
Closes #548.
Breaking Changes
Additional Info