Skip to content

Remove export code #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Remove export code #439

merged 1 commit into from
Aug 10, 2020

Conversation

cap-Bernardito
Copy link
Member

@cap-Bernardito cap-Bernardito commented Aug 10, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Remove export code

Breaking Changes

Yes.

Additional Info

if you want to get сss, use css-loader. In other cases, you can use raw-loader.


Loader should not change type of output based on index in loaders, it is not cacache, and can lead to very strange errors

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #439 into master will increase coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
+ Coverage   92.12%   92.74%   +0.61%     
==========================================
  Files           5        5              
  Lines         127      124       -3     
  Branches       38       37       -1     
==========================================
- Hits          117      115       -2     
+ Misses         10        9       -1     
Impacted Files Coverage Δ
src/index.js 89.65% <ø> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eec4dd...31f33cb. Read the comment docs.

@alexander-akait alexander-akait merged commit e3f8ee4 into master Aug 10, 2020
@alexander-akait alexander-akait deleted the refactor-remove-export-code branch August 10, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants