Skip to content

Update README.md to reflect css-modules #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

justin808
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 19, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: justin808 / name: Justin Gordon (7c63f81)

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you accept CLA?

@justin808
Copy link
Contributor Author

@pulkitkkr and I have been spending hours trying to debug why we get errors on ordering when splitting chunks.

Maybe the code should be updated to never worry about the ordering for CSS-modules automatically?

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 90.34% // Head: 90.34% // No change to project coverage 👍

Coverage data is based on head (7c63f81) compared to base (6b1f18a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #980   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files           5        5           
  Lines         829      829           
  Branches      221      221           
=======================================
  Hits          749      749           
  Misses         70       70           
  Partials       10       10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait
Copy link
Member

Maybe the code should be updated to never worry about the ordering for CSS-modules automatically?

That is not safe 😞 So we should warning about it

@justin808
Copy link
Contributor Author

What's left to get this merged?

@alexander-akait alexander-akait merged commit 865b767 into webpack-contrib:master Oct 21, 2022
@alexander-akait
Copy link
Member

Thank you

@justin808
Copy link
Contributor Author

Maybe the code should be updated to never worry about the ordering for CSS-modules automatically?
That is not safe 😞 So we should warning about it

Is that the case where one is mixing some CSS modules and global CSS?

@justin808 justin808 deleted the patch-1 branch October 21, 2022 22:21
@alexander-akait
Copy link
Member

I recommend to avoid it, except global styles like fonts/animations/counter styles/etc

@justin808
Copy link
Contributor Author

I recommend to avoid it, except global styles like fonts/animations/counter styles/etc

What is "it" to avoid? mixing both modules and non-modules?

BTW, we owns https://github.com/shakacode/sass-resources-loader which allows global variables to be used within sass modules.

@alexander-akait
Copy link
Member

alexander-akait commented Oct 21, 2022

What is "it" to avoid? mixing both modules and non-modules?

Yes, except global styels for all application, otherwise you need manually to check an order in many places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants