-
-
Notifications
You must be signed in to change notification settings - Fork 384
Update README.md to reflect css-modules #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you accept CLA?
@pulkitkkr and I have been spending hours trying to debug why we get errors on ordering when splitting chunks. Maybe the code should be updated to never worry about the ordering for CSS-modules automatically? |
Codecov ReportBase: 90.34% // Head: 90.34% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #980 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 5 5
Lines 829 829
Branches 221 221
=======================================
Hits 749 749
Misses 70 70
Partials 10 10 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
That is not safe 😞 So we should warning about it |
What's left to get this merged? |
Thank you |
Is that the case where one is mixing some CSS modules and global CSS? |
I recommend to avoid it, except global styles like fonts/animations/counter styles/etc |
What is "it" to avoid? mixing both modules and non-modules? BTW, we owns https://github.com/shakacode/sass-resources-loader which allows global variables to be used within sass modules. |
Yes, except global styels for all application, otherwise you need manually to check an order in many places |
This PR contains a:
Motivation / Use-Case
Breaking Changes
Additional Info