Skip to content

EmitFile: addition of the "emitFile" option, would close #713 #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

EmitFile: addition of the "emitFile" option, would close #713 #714

wants to merge 5 commits into from

Conversation

ferdinando-ferreira
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Addition of the option emitFile, similar to the one existing in other plugins like file-loader (see: https://webpack.js.org/loaders/file-loader/#emitfile

Breaking Changes

None

Additional Info

Would close the ticket #713

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #714 (159a027) into master (6ae4c3e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #714      +/-   ##
==========================================
+ Coverage   89.67%   89.69%   +0.01%     
==========================================
  Files           6        6              
  Lines         775      776       +1     
  Branches      239      239              
==========================================
+ Hits          695      696       +1     
  Misses         77       77              
  Partials        3        3              
Impacted Files Coverage Δ
src/index.js 88.05% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ae4c3e...54e7bc0. Read the comment docs.

@ferdinando-ferreira ferdinando-ferreira changed the title Addition of the "emitFile" option, would close #713 EmitFile: addition of the "emitFile" option, would close #713 Mar 6, 2021
@ferdinando-ferreira
Copy link
Author

@alexander-akait: Closing this PR to provide a simpler use case and fix the merge issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant