fix(contenthash): do not generate mini-css contenthash for chunks without css modules #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout css modules Fixes webpack-contrib#680
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
===========================================
- Coverage 88.75% 71.38% -17.38%
===========================================
Files 11 11
Lines 676 678 +2
Branches 184 184
===========================================
- Hits 600 484 -116
- Misses 73 178 +105
- Partials 3 16 +13
Continue to review full report at Codecov.
|
| const modules = Array.from( | ||
| this.getChunkModules(chunk, chunkGraph) | ||
| ).filter((module) => module.type === MODULE_TYPE); | ||
| if (modules.length) { |
There was a problem hiding this comment.
Let's use continue, it is faster, just put // eslint-ignore if linter will report about it (we need disable this rule, because we have more problems with it)
|
Thanks for the PR, I solved it with better perf, also found place there we can reduce runtime more, so it is only first place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Fixes #680
Breaking Changes
None
Additional Info