Skip to content

add types for ts support and support webpack v5 config #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

YanYuanFE
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

add types for ts support and support webpack v5 config

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #594 (5ac0836) into master (bb09d75) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #594   +/-   ##
=======================================
  Coverage   91.16%   91.16%           
=======================================
  Files           9        9           
  Lines         543      543           
  Branches      145      145           
=======================================
  Hits          495      495           
  Misses         44       44           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb09d75...5ac0836. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we should use ts docs to generate types, also it was implemented after webpack@5 stable release

@PodaruDragos
Copy link

@alexander-akait are there any plans to add types directly in this package and not rely on @types/mini-css-extract-plugin ?

@alexander-akait alexander-akait mentioned this pull request Jan 14, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants