Skip to content

test: fix invalid test and source map test #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2019
Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #285

Breaking Changes

No

Additional Info

To disable source maps generation you need set sourceMap: false for css-loader and set devtools: false, we will try to fix and simplify it in webpack@5

@codecov
Copy link

codecov bot commented Dec 25, 2019

Codecov Report

Merging #481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #481   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files           5        5           
  Lines         426      426           
  Branches       94       94           
=======================================
  Hits          377      377           
  Misses         47       47           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b197757...7426270. Read the comment docs.

@alexander-akait alexander-akait merged commit aa22e44 into master Dec 25, 2019
@alexander-akait alexander-akait deleted the test-source-maps branch December 25, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the sourceMap option in README
1 participant