feat: export class names as an ESM #336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexander-akait
requested changes
Jan 9, 2019
|
@evilebottnawi from an application's perspective or that it might break integration with other plugins? |
Also we need first implement this in |
kgrz
reviewed
Jun 5, 2019
| Object.keys(locals).forEach((exportName) => { | ||
| const className = locals[exportName]; | ||
|
|
||
| resultSource += `\nexport const ${exportName} = '${className}';`; |
There was a problem hiding this comment.
Will this work with class names that have hyphens in them? Especially if css-loader isn't specifically configured to convert the locals into camelCase or something.
|
Done in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Closes #43.
Consuming class names as an ESM with named exports makes Webpack to include them as separate bindings, which in turn, allows minifires to mangle them or inline those class names.
It all leads to a reduced size of a bundle, which, in case of our app, was
~30Kibof a minified code.Breaking Changes
This a backward-compatible change due to an interoperability between ESM and CJS implemented in Webpack.
Additional Info
Tests weren't updated because none of them assert exports of JS modules. Unfortunately, I've no idea how it can be tested given the existing cases.