fix(index): dynamic css loading support for older browsers (#294) #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This build of WebKit is the one (and previous) shipped with iOS 6. Do we really need to support something that old? |
alexander-akait
requested review from
ooflorent,
alexander-akait and
michael-ciniawsky
and removed request for
ooflorent and
sokra
|
There are still 3% mobile devices using Android 4.3 and below. Yes, the number seems small, however when those users contact you and complain about the app is not working on his phone, coders still need to fix it. Every user matters. 😀 |
alexander-akait
approved these changes
Oct 22, 2018
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
This PR solve the issue:
linkelement load event not fired on old browser #294 by usingonerrorevent ofimgelement if user's browser is old enough.Breaking Changes
None
Additional Info
None