Skip to content

docs(readme): add media-query-splitting-plugin (Media Query Plugin) #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2018
Merged

docs(readme): add media-query-splitting-plugin (Media Query Plugin) #269

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dff1205
Update README.md
mike-diamond Sep 10, 2018
d3f7cda
Update README.md
mike-diamond Sep 10, 2018
8214bd4
Update README.md
mike-diamond Sep 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,8 @@ For long term caching use `filename: "[contenthash].css"`. Optionally add `[name

If you'd like to extract the media queries from the extracted CSS (so mobile users don't need to load desktop specific CSS anymore) you should use the [media-query-plugin](https://github.com/SassNinja/media-query-plugin). It will take over the filename option of the mini-css-extract-plugin and recognize its generated CSS chunks.

Or you can use [media-query-splitting-plugin](https://github.com/mike-diamond/media-query-splitting-plugin), it will handle mobile, tablet and desktop styles splitting for each CSS chunk in your bundle without any configuration, just add it to the webpack plugins.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the description more generic e.g

- you should use the [media-query-plugin](https://github.com/SassNinja/media-query-plugin) ...
+ you should use one of the following plugins ...

and make a list for the plugins instead

... its generated CSS chunks.
 
- [Media Query Plugin](media-query-plugin)
- [Media Query Splitting Plugin](media-query-splitting-plugin)

[media-query-plugin]: https://github.com/SassNinja/media-query-plugin
[media-query-splitting-plugin]: https://github.com/mike-diamond/media-query-splitting-plugin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed



<h2 align="center">Maintainers</h2>

Expand Down