fix(index): loading order mismatch

[ShanaMaid]

This PR contains a:

• bugfix
• new feature
• code refactor
• test update
• typo fix
• metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

[jsf-clabot]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sokra
❌ ShanaMaid

[alexander-akait]

Please provide minimum reproducible test repo, also you should add tests to your PR

[ShanaMaid]

test rep
#188 (comment)

[sokra]

This looks incorrect to me.

Also there no tests so it seem safe to assume it's incorrect.

The repro is far too big for me to try it. Please create a minimal repro. Start from a new empty repo.

[ShanaMaid]

@sokra
this mini rep offered by @boraturant ， difference is that I use local mini-css-extract-plugin builded by my pr #236.
comparing with [email protected], file change is 856da5e

it seems to be that sort func is not correct.

[alexander-akait]

@ShanaMaid Without minimum reproducible repo and tests, we can't merge this

[ShanaMaid]

I had added test @evilebottnawi

[jarandmi]

chunkGroup.getModuleIndex2() is often returned as undefined (i'm not sure why). This should also be handled in the if (typeof chunkGroup.getModuleIndex2 === 'function') block. If undefined, it should be sorted to the bottom of the array.

modules.sort((a, b) => { 
        let aSort = chunkGroup.getModuleIndex2(a) || 0
        let bSort = chunkGroup.getModuleIndex2(b) || 0

        if(aSort < bSort){
          return 1
        }
        return -1
});

[sokra]

chunkGroup.getModuleIndex2() is often returned as undefined (i'm not sure why)

This should be investigated...

[sokra]

@ShanaMaid I copied your test case and ran it for the fallback code path too. It was broken with your change, but I could fix it by reverting to the original code. This leaves this PR without code change but good testcases.

[jarandmi]

@sokra : It happends only when i use this in my webpack config, to get all CSS in one file:

            splitChunks: {
                cacheGroups: {
                    styles: {
                        name: 'style',
                        test: module =>
                            module.nameForCondition &&
                            /\.(scss|css)$/.test(module.nameForCondition()),
                        chunks: 'all',
                    },
                },
            },
        }

[jarandmi]

Is there no test for the Extracting all CSS in a single file case?

[sokra]

@jarandmi let's discuss this in your PR.

This PR seem to be done.

[sokra]

@evilebottnawi This PR is good to be merged, once @ShanaMaid signed the CLA.

[alexander-akait]

@ShanaMaid what issue it is solved?

[alexander-akait]

Looks here only tests, merge