-
-
Notifications
You must be signed in to change notification settings - Fork 384
Update README.md #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #187
Conversation
Update README.md to tell user they can specify a custom path in `url`, relative or absolute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests for this feature to avoid regressions in future?
I have add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't modify original tests, please add new, thanks! Also can we use other path to test like /my/own/path/
.
I have add a new test case named simple-publicpath. The result is correct. Thank you for you advice. |
Update README.md to tell user they can specify a custom path in
url
, relative or absoluteThis PR contains a:
Motivation / Use-Case
To help user comprehend the guide.
Breaking Changes
Additional Info