Skip to content

Add an advanced configuration example in README #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Add an advanced configuration example in README #101

merged 1 commit into from
Apr 18, 2018

Conversation

sylver
Copy link
Contributor

@sylver sylver commented Apr 17, 2018

As discussed with @evilebottnawi in #9, here is a PR adding an advanced example in the docs to avoid confusion and problems with the use of this plugin and the style-loader, especially when one wants to have HMR in development and its styles extracted for production builds.

@jsf-clabot
Copy link

jsf-clabot commented Apr 17, 2018

CLA assistant check
All committers have signed the CLA.

@sylver
Copy link
Contributor Author

sylver commented Apr 17, 2018

Not sure about what to do here @evilebottnawi ... I already signed the CLA and the email used for the commit is in my github account (not the primary though, maybe that's the problem ?).
EDIT : nevermind, it seems it was a delay, it is marked as signed now.

@joshwiens joshwiens merged commit d7d0afc into webpack-contrib:master Apr 18, 2018
@sylver sylver deleted the improve-documentation-configuration branch April 18, 2018 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants