Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

feat - Use use/fallback pair at extract over loader/fallbackLoader` #388

Merged
merged 3 commits into from
Feb 4, 2017

Conversation

bebraw
Copy link
Contributor

@bebraw bebraw commented Feb 1, 2017

Closes #382.

@bebraw bebraw added this to the 2.0 final milestone Feb 1, 2017
@codecov-io
Copy link

codecov-io commented Feb 1, 2017

Codecov Report

Merging #388 into master will increase coverage by 0.25%.

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   87.06%   87.32%   +0.25%     
==========================================
  Files           5        6       +1     
  Lines         348      355       +7     
  Branches       71       74       +3     
==========================================
+ Hits          303      310       +7     
  Misses         45       45
Impacted Files Coverage Δ
schema/loader-schema.js 100% <100%> (ø)
index.js 87.61% <100%> (ø)
...rib/extract-text-webpack-plugin/ExtractedModule.js
...pack-contrib/extract-text-webpack-plugin/loader.js
...ib/extract-text-webpack-plugin/schema/validator.js
...bpack-contrib/extract-text-webpack-plugin/index.js
...extract-text-webpack-plugin/OrderUndefinedError.js
schema/validator.js 100% <ø> (ø)
loader.js 89.28% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e9780...e07b492. Read the comment docs.

fallbackLoader: "style-loader",
loader: "css-loader?sourceMap",
fallback: "style-loader",
use: "css-loader?sourceMap",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to use options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll do that. Thanks for the heads up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@bebraw bebraw merged commit 313a08a into webpack-contrib:master Feb 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants