Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

#cache publicPath #305

Closed
wants to merge 1 commit into from
Closed

#cache publicPath #305

wants to merge 1 commit into from

Conversation

githoniel
Copy link

cache publicPath to fixed the bug that publicPath only take effect for the first file #246

@jsf-clabot
Copy link

jsf-clabot commented Dec 11, 2016

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Dec 11, 2016

Codecov Report

Merging #305 into webpack-1 will increase coverage by -0.13%.

@@              Coverage Diff              @@
##           webpack-1     #305      +/-   ##
=============================================
- Coverage      80.76%   80.64%   -0.13%     
=============================================
  Files              4        4              
  Lines            338      341       +3     
  Branches          71       72       +1     
=============================================
+ Hits             273      275       +2     
- Misses            65       66       +1
Impacted Files Coverage Δ
loader.js 83.13% <75%> (-0.62%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db50ee...4628450. Read the comment docs.

@bebraw
Copy link
Contributor

bebraw commented Jan 29, 2017

@githoniel Is there some particular reason why you closed this?

@githoniel
Copy link
Author

@bebraw it actually fixed the bugs in my webpack1 projects,but i have upgraded to webpack2 and those project works well without it

@githoniel githoniel reopened this Feb 2, 2017
@bebraw
Copy link
Contributor

bebraw commented Feb 2, 2017

Alright. Our focus is on webpack 2 so I guess it's safe to close this again. Thanks for clarification.

@bebraw bebraw closed this Feb 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants