Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

2.0.0-rc.2 might break the build (ajv) #380

Closed
johakr opened this issue Jan 30, 2017 · 2 comments
Closed

2.0.0-rc.2 might break the build (ajv) #380

johakr opened this issue Jan 30, 2017 · 2 comments

Comments

@johakr
Copy link

johakr commented Jan 30, 2017

Listing ajv in devDependencies and not explicitly in dependencies might break the build of packages relying on extract-text-webpack-plugin. ajv might not be installed at all or might be resolved to a wrong version.

In our specific project, we have [email protected] as dependency in our main package.json, leading to the following error, since extract-text-webpack-plugin expects ajv to be version 4 but finds version 5:

Error: no schema with key or ref "http://json-schema.org/draft-04/schema#"

@michael-ciniawsky
Copy link
Member

@amazingcode-de Yep that should be fixed, good catch.
Do you want to send a PR for it?
Otherwise I will do it when I have a few minutes :)

@bebraw
Copy link
Contributor

bebraw commented Jan 30, 2017

Merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants