Skip to content

refactor: drop getLocalIdent compatibility with webpack@2 and webpack@3 #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Drop compatibility getLocalIdent option with webpack@2 and webpack@3

Breaking Changes

In theory - yes, but loader require webpack@4 and it does not make sense so no

Additional Info

no

@codecov
Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #829 into master will increase coverage by 1.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #829      +/-   ##
==========================================
+ Coverage   98.49%   99.74%   +1.24%     
==========================================
  Files          10       10              
  Lines         399      393       -6     
  Branches       96       92       -4     
==========================================
- Hits          393      392       -1     
+ Misses          5        1       -4     
+ Partials        1        0       -1
Impacted Files Coverage Δ
lib/utils.js 98.21% <100%> (+7.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be29be0...18d3ce7. Read the comment docs.

@alexander-akait alexander-akait merged commit 947e666 into master Nov 30, 2018
@alexander-akait alexander-akait deleted the refactor-getLocalIdent branch November 30, 2018 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant