Skip to content

refactor: url replacer logic #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Reduce url items for perf reason and refactor

Breaking Changes

No

Additional Info

No

@alexander-akait alexander-akait force-pushed the refactor-url-replacer-logic branch from 97b6373 to cf3aa44 Compare November 30, 2018 11:51
@codecov
Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #828 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
+ Coverage   98.48%   98.49%   +<.01%     
==========================================
  Files          10       10              
  Lines         397      399       +2     
  Branches       92       96       +4     
==========================================
+ Hits          391      393       +2     
  Misses          5        5              
  Partials        1        1
Impacted Files Coverage Δ
lib/loader.js 100% <100%> (ø) ⬆️
lib/plugins/postcss-url-parser.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e52d26...cf3aa44. Read the comment docs.

@alexander-akait alexander-akait merged commit be29be0 into master Nov 30, 2018
@alexander-akait alexander-akait deleted the refactor-url-replacer-logic branch November 30, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant