Skip to content

refactor: importItemMatcher util #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2018
Merged

refactor: importItemMatcher util #823

merged 1 commit into from
Nov 29, 2018

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Move to utils for easy maintenance.

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #823 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #823      +/-   ##
=========================================
- Coverage   98.31%   98.3%   -0.01%     
=========================================
  Files          12      12              
  Lines         416     414       -2     
  Branches       96      98       +2     
=========================================
- Hits          409     407       -2     
  Misses          6       6              
  Partials        1       1
Impacted Files Coverage Δ
lib/loader.js 100% <100%> (ø) ⬆️
lib/utils.js 91.54% <100%> (+1.38%) ⬆️
lib/localsLoader.js 93.33% <100%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9aa73c...5da1b05. Read the comment docs.

@alexander-akait alexander-akait merged commit 2e62346 into master Nov 29, 2018
@alexander-akait alexander-akait deleted the refactor-utils branch November 29, 2018 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant