Skip to content

refactor: postcss-parser #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2018
Merged

refactor: postcss-parser #821

merged 1 commit into from
Nov 29, 2018

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

use only postcss-value-parser. Also use toString() in plugin, because in future we will reuse postcss ast and some plugins can store params and value not in string format.

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #821 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
- Coverage   98.38%   98.31%   -0.07%     
==========================================
  Files          12       12              
  Lines         433      416      -17     
  Branches      102       96       -6     
==========================================
- Hits          426      409      -17     
  Misses          6        6              
  Partials        1        1
Impacted Files Coverage Δ
lib/plugins/index.js 100% <100%> (ø) ⬆️
lib/processCss.js 100% <100%> (ø) ⬆️
lib/plugins/postcss-icss-parser.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef3c26...3b2bcca. Read the comment docs.

@alexander-akait alexander-akait merged commit 3b573a9 into master Nov 29, 2018
@alexander-akait alexander-akait deleted the refactor-postcss-parser branch November 29, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant