chore(package): update postcss v5.0.6...v6.0.23 (dependencies)
#735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@evilebottnawi, what does that mean? Any changes from me? Would I have to get the tests passing for this new version of PostCSS? |
|
@mikeumus css-loader works on any version node@js, but postcss only for 4 version, it is breaking change |
|
@evilebottnawi, I see. Anything I can do on my end? |
|
@mikeumus it is very big work 😞 first we should create new loader for css modules and remove this from default |
|
@evilebottnawi, I see, okay. |
cs-eddy
approved these changes
Aug 1, 2018
michael-ciniawsky
changed the title
postcss-modules-scope incompatible with PostCSS v5.xpostcss v5.0.6...v6.0.23 (dependencies)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Summary
Simple fix for #691