-
-
Notifications
You must be signed in to change notification settings - Fork 608
[WIP] refactor(loader): v2.0.0 #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e28bdd
to
5eff4de
Compare
|
Name | Status |
---|---|
Default | ✅ |
CSS URLs | ✅ |
CSS Imports | ✅ |
CSS Runtime | ❔ |
Options - url | ✅ |
Options - import | ✅ |
Options - sourceMap | ✅ |
14d826f
to
f4453d2
Compare
143e146
to
6d1b84f
Compare
6d1b84f
to
872cf94
Compare
872cf94
to
2202572
Compare
3 tasks
@michael-ciniawsky any way I can help with this? I believe this would include custom exports support. |
mikeumus
reviewed
Jun 25, 2018
"postcss-modules-scope": "^1.1.0", | ||
"postcss-modules-values": "^1.3.0", | ||
"loader-utils": "^1.1.0", | ||
"postcss": "^6.0.15", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line would solve #691 in my case at least.
This was referenced Jul 4, 2018
Merged
Closing in favor of #748 (for now)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the README?
Summary
Does this PR introduce a breaking change?
Other information
BREAKING CHANGE: Sets
engines
to"node": ">= 6.9.0 || >= 8.9.0"
BREAKING CHANGE: Drops support for Webpack
v2.x